This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Manually clear orphaned recaptcha challenge overlay in android webviews #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langleyd
changed the title
langleyd
changed the title
langleyd
changed the title
…element-hq/matrix-react-sdk into langleyd/fix_captcha_on_android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting the captcha does in "componentWillUnmount" does not clear the challenge overlay from the body in android webviews(I confirmed it's getting called with a valid value for
captchaWidgetId).This pr adds a workaround to search for orphaned iframe and remove it from the body.
We can remove this when the "mobile_register" page is retired(i.e. MAS works with matrix.org).